[PATCH] D77860: [Object] Change uint32_t getSymbolFlags() to Expected<uint32_t> getSymbolFlags().

[Xing GUO via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 257187.
Higuoxing added a comment.

Addressed comments.

- Add TODO tags on untested paths.
- Use shorter comments to fit in a single line.
- Remove unrelated changes.
- Use `type Var = catFail(mayFailFunc())` style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77860/new/

https://reviews.llvm.org/D77860

Files:
  llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h
  llvm/include/llvm/Object/COFF.h
  llvm/include/llvm/Object/COFFImportFile.h
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/include/llvm/Object/IRObjectFile.h
  llvm/include/llvm/Object/MachO.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/include/llvm/Object/SymbolicFile.h
  llvm/include/llvm/Object/TapiFile.h
  llvm/include/llvm/Object/Wasm.h
  llvm/include/llvm/Object/XCOFFObjectFile.h
  llvm/lib/ExecutionEngine/Orc/Mangling.cpp
  llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/JITSymbol.cpp
  llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
  llvm/lib/Object/ArchiveWriter.cpp
  llvm/lib/Object/COFFObjectFile.cpp
  llvm/lib/Object/IRObjectFile.cpp
  llvm/lib/Object/MachOObjectFile.cpp
  llvm/lib/Object/ObjectFile.cpp
  llvm/lib/Object/TapiFile.cpp
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/lib/Object/XCOFFObjectFile.cpp
  llvm/tools/dsymutil/DebugMap.cpp
  llvm/tools/dsymutil/MachODebugMapParser.cpp
  llvm/tools/llvm-nm/llvm-nm.cpp
  llvm/tools/llvm-objdump/MachODump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-size/llvm-size.cpp
  llvm/tools/sancov/sancov.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77860.257187.patch
Type: text/x-patch
Size: 31032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/ede30120/attachment.bin>