[PATCH] D78072: [lld][WebAssembly] Do not require --shared-memory with --relocatable

Mon Apr 13 20:06:13 PDT 2020

sbc100 added a comment.

lgtm with a couple of questions..

================
Comment at: lld/wasm/Writer.cpp:436

   if (disallowed.count("atomics") && config->sharedMemory)
     error("'atomics' feature is disallowed by " + disallowed["atomics"] +
----------------
What about all these other tests that also depend on the sharedMemory flag?

I would have thought that in relocatable mode we simply never look at the sharedMemory flag.  In fact it should probably be a link error to use `--shared-memory` and `--relocatable` at the same time?

Also. what about `--check-features/--no-check-features` do they make sense with `--relocatable`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78072/new/

https://reviews.llvm.org/D78072