[llvm] 5e7b98f - Fix an unused-variable warning in Release mode.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 17:59:39 PDT 2020


Could you roll this into the assertion (per the last point in
https://llvm.org/docs/CodingStandards.html#assert-liberally discussing how
to address unused variable warnings)

On Thu, Apr 9, 2020 at 1:35 PM James Y Knight via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: James Y Knight
> Date: 2020-04-09T16:34:55-04:00
> New Revision: 5e7b98fe7510c11d1992b0282776846b1b1d3c2b
>
> URL:
> https://github.com/llvm/llvm-project/commit/5e7b98fe7510c11d1992b0282776846b1b1d3c2b
> DIFF:
> https://github.com/llvm/llvm-project/commit/5e7b98fe7510c11d1992b0282776846b1b1d3c2b.diff
>
> LOG: Fix an unused-variable warning in Release mode.
>
> Added:
>
>
> Modified:
>     llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
> b/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
> index f9c34a24be99..e782fc194791 100644
> --- a/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
> +++ b/llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
> @@ -192,6 +192,7 @@ PPCMCCodeEmitter::getMemRI34PCRelEncoding(const MCInst
> &MI, unsigned OpNo,
>    if (MO.isExpr()) {
>      const MCExpr *Expr = MO.getExpr();
>      const MCSymbolRefExpr *SRE = cast<MCSymbolRefExpr>(Expr);
> +    (void)SRE;
>      assert(SRE->getKind() == MCSymbolRefExpr::VK_PCREL &&
>             "VariantKind must be VK_PCREL");
>      Fixups.push_back(
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200413/a0a0858f/attachment.html>


More information about the llvm-commits mailing list