[PATCH] D77987: [test-suite] Move lit test result codes into llvm/lit

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: litsupport/test.py:38
         if not os.path.exists(context.executable):
-            return lit.Test.Result(NOEXE, "Executable '%s' is missing" %
+            return lit.Test.Result(lit.Test.NOEXE, "Executable '%s' is missing" %
                                    context.executable)
----------------
yln wrote:
> I think the existing category of `UNRESOLVED` would be a good semantic fit here.
I mentioned something similar in the other review [0] but FTR: 

To me, unresolved doesn't capture the fact that the compile stage of the (lnt-based) process failed to produce an executable. Unresolved is a generic term which could mean a lo of things, e.g., some system dependence were missing, the architecture did not match, the source download failed, ...


[0] https://reviews.llvm.org/D77986#1979402


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77987/new/

https://reviews.llvm.org/D77987