[PATCH] D77953: GlobalISel: Fix casted unmerge of G_CONCAT_VECTORS

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with nits.



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:469
+
+          // Handle split to smaller vectors, with converssions.
+          // %2(<8 x s8>) = G_CONCAT_VECTORS %0(<4 x s8>), %1(<4 x s8>)
----------------
typo converssions


================
Comment at: llvm/include/llvm/Support/LowLevelTypeImpl.h:150
+  LLT divide(int Factor) const {
+    assert(Factor != 1);
+    if (isVector())
----------------
Can we assert that the type is divisible by Factor?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77953/new/

https://reviews.llvm.org/D77953