[PATCH] D77991: [llvm][NFC] CallSite removal from inliner-related files

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 17:25:11 PDT 2020


mtrofin added inline comments.


================
Comment at: llvm/lib/CodeGen/SafeStack.cpp:346-347
         // the function being called.
-        ImmutableCallSite::arg_iterator B = CS.arg_begin(), E = CS.arg_end();
-        for (ImmutableCallSite::arg_iterator A = B; A != E; ++A)
+        auto B = CS.arg_begin(), E = CS.arg_end();
+        for (auto A = B; A != E; ++A)
           if (A->get() == V)
----------------
dblaikie wrote:
> Probably commit things like this independently (before/after this refactor, whichever suits better) without precommit review.
In this case, we needed ImmutableCallSite::arg_iterator -> auto because we don't want ImmutableCallSite 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77991/new/

https://reviews.llvm.org/D77991





More information about the llvm-commits mailing list