[PATCH] D77741: [FileCheck] Better diagnostic for format conflict

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre updated this revision to Diff 257128.
thopre marked 2 inline comments as done.
thopre added a comment.

- Remove default case in ExplicitFormat::toString() and move llvm_unreachable outside the switch block
- Add testcase for getImplicitFormat with errors on both operands


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77741/new/

https://reviews.llvm.org/D77741

Files:
  llvm/lib/Support/FileCheck.cpp
  llvm/lib/Support/FileCheckImpl.h
  llvm/test/FileCheck/numeric-expression.txt
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77741.257128.patch
Type: text/x-patch
Size: 30716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200413/b1f4898a/attachment-0001.bin>