[PATCH] D77576: [globalisel] Add lost debug locations verifier

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Daniel,

What is the compile time impact of this change?

Is there a way to make the callers agnostic to the kind of observers we are dealing with?

Basically, I like the observer idea for checking the debug information, but I don't like that:

1. We have to add a bunch of checkpoint calls all over the place
2. We have to specifically carry this observer around instead of having it being with the other observers (`AuxObservers` argument)

Bottom line, it feels intrusive and if we have to do that everywhere I am afraid we won't be able to scale.

I am fine with moving forward with that patch for the time being, but I think we have to rethink our strategy long term.

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77576/new/

https://reviews.llvm.org/D77576