[PATCH] D77986: [lit] Move llvm-test-suite result codes into llvm/lit

Mon Apr 13 13:35:06 PDT 2020

jdoerfert added a comment.

In D77986#1978333 <https://reviews.llvm.org/D77986#1978333>, @yln wrote:

> Hi Johannes,
>
> As Joel mentioned: I already added a SKIPPED category: tests that should have been executed but weren't.
>  I am planning to add one more: FILTERED: tests that are discovered but, are filtered out.
>
> Please explain what benefit having a separate category for NOEXE offers; and why it is considered a failure?  My understanding is that `--no-execute` is mostly used for benchmarking lit itself (pass/fail doesn't matter there?).
>
> Thanks!

As I mentioned in the commit message, without this patch running `lnt runtest test-suite` can fail with an obscure message and not produce a result. It is considered a failure because this is the definition that I moved from the test-suite (D77987 <https://reviews.llvm.org/D77987>).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77986/new/

https://reviews.llvm.org/D77986