[PATCH] D77231: [lld] Support --lto-emit-asm and --plugin-opt=emit-asm

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Mostly good, with a few nits.



================
Comment at: lld/ELF/Options.td:528
+def plugin_opt_emit_asm: F<"plugin-opt=emit-asm">,
+  Alias<lto_emit_asm>, HelpText<"Alias for -lto-emit-asm">;
 def: J<"plugin-opt=jobs=">, Alias<thinlto_jobs>, HelpText<"Alias for -thinlto-jobs">;
----------------
`--lto-emit-asm`


================
Comment at: lld/test/ELF/lto/emit-asm.ll:1
+; RUN: llvm-as %s -o %t.o
+; RUN: ld.lld --lto-emit-asm -shared %t.o -o - | FileCheck %s
----------------
`; REQUIRES: x86`


================
Comment at: lld/test/ELF/lto/emit-asm.ll:3
+; RUN: ld.lld --lto-emit-asm -shared %t.o -o - | FileCheck %s
+; RUN: ld.lld --plugin-opt=emit-asm --plugin-opt=lto-partitions=2\
+; RUN:    -shared %t.o -o %t2.s
----------------
Nit: You can join the two lines


================
Comment at: lld/test/ELF/lto/emit-asm.ll:5
+; RUN:    -shared %t.o -o %t2.s
+; RUN: cat %t2.s %t2.s1 > %t3.s
+; RUN: FileCheck --input-file %t3.s %s
----------------
`cat %t2.s %t2.s1 | FileCheck %s`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77231/new/

https://reviews.llvm.org/D77231