[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 12:26:24 PDT 2020


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/Target/TargetMachine.cpp:263
+  if (getTargetTriple().isOSBinFormatXCOFF()) {
+    return TLOF->getTargetSymbol(GV, *this);
+  }
----------------
**To reviewers**, 
I'm not sure if this is a preferred way to inject target specific behavior. Or we want to override TargetMachine::getSymbol directly instead.
Please let me know if you find the other way is more appealing, or you could think of a better way to inject this target specific behavior.
Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78045/new/

https://reviews.llvm.org/D78045





More information about the llvm-commits mailing list