[PATCH] D77213: Handle part-word LL/SC in atomic expansion pass

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz marked an inline comment as done.
kparzysz added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1350-1352
+  // The newly inserted PHI nodes may be unnecessary, for example, they
+  // may have only one argument. Simplify the code eliminating those
+  // PHI that can be easily removed. Since the "exit value" (LoadedFull)
----------------
jyknight wrote:
> What's all this complication about?
> 
> I find it hard to imagine putting this kind of simplification code inline here is the best way to go about this.
This complication is about having one or two of the tests pass with minimal changes.  It checks all statements, and I'd have to annotate it with the extra PHIs (with single operand, or with multiple identical incoming values).  I thought I'd be objectionable, so I added this cleanup code.

If the test alteration is ok, I can remove this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77213/new/

https://reviews.llvm.org/D77213