[PATCH] D77870: [MLIR] Introduce utility to hoist affine if/else conditions

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 11:53:06 PDT 2020


dcaballe accepted this revision.
dcaballe added a comment.

Thanks for addressing the comments. Just a minor comment. Otherwise, LGTM. Please, wait for the other reviewers.



================
Comment at: mlir/test/Dialect/Affine/loop-unswitch.mlir:27
+// CHECK-NEXT:        affine.load %arg0[%[[J]]]
+// CHECK-NEXT:        affine.load %arg1[%[[J]]]
+// CHECK-NEXT:        call
----------------
Better capture `arg0` and `arg1` as variables


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77870/new/

https://reviews.llvm.org/D77870





More information about the llvm-commits mailing list