[PATCH] D77858: [llvm-xray] Add llvm-xray extract support for 32 bit ARM

Mon Apr 13 11:53:02 PDT 2020

MaskRay added inline comments.

================
Comment at: llvm/test/tools/llvm-xray/ARM/elf32-pic.yaml:1
+--- !ELF
+FileHeader:
----------------
A non-test supplement file should be placed under `Inputs/` , otherwise it can be interpreted as a test.

lit will consider it an `unresolved test`

================
Comment at: llvm/test/tools/llvm-xray/ARM/elf32-pic.yaml:9
+  Entry:           0x000000000000042C
+ProgramHeaders:
+  - Type:            PT_PHDR
----------------
Most program headers and sections in this file are not needed. You can figure out the minimum information `llvm-xray extract` expects and just provide that much. The extra fields are distracting.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77858/new/

https://reviews.llvm.org/D77858