[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:1277
 
+  bool FoundPrefix = false;
   while (1) {
----------------
I think a clearer name is `FoundUsedPrefix`.


================
Comment at: llvm/lib/Support/FileCheck.cpp:1375-1376
+  // and use the first prefix as a filler for the error message.
+  // We do not allow using -implicit-check-not when an explicitly specified
+  // check prefix is not present in the input buffer.
+  bool IsDefaultPrefix =
----------------
What if the only explicitly specified prefix is `CHECK`?  Oddly, it happens.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78024/new/

https://reviews.llvm.org/D78024