[PATCH] D77425: [NFC] Make Type::isVectorTy call isa<VectorType>

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 10:45:11 PDT 2020


dblaikie added a comment.

What's the motivation for this change compared to the previous code? This looks problematic in ways I can't really see a fix for. While the originally proposed patch would fail to compile if you included Type.h without DerivedType.h - the new version will compile but fail to link (a & probably should fail to compile - it will if you compile with -Wundefined-inline)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77425/new/

https://reviews.llvm.org/D77425





More information about the llvm-commits mailing list