[PATCH] D77852: Outline CFI Instructions in Tail Calls

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added a comment.

Thanks Andrew! A few coments inline and below:

- does this need an X86 test as well? I'm not sure what the state of the outliner is there.
- please grab std::vector<MCCFIInstruction> by `const &`.
- a `MachineBasicBlock::iterator` is usually called `MBBI` in codegen.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5866
+  // We check to see if CFI Instructions are present, and if they are
+  // we find the number of CFI Instructionz in the candidates.
+  unsigned CFICount = 0;
----------------
s/Instructionz/Instructions/


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:8686
+  // We check to see if CFI Instructions are present, and if they are
+  // we find the number of CFI Instructionz in the candidates.
+  unsigned CFICount = 0;
----------------
s/Instructionz/Instructions/


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-cfi-tail-some.mir:23
+    ; CHECK: liveins: $lr
+    ; CHECK: frame-setup CFI_INSTRUCTION def_cfa $w28, 16
+    ; CHECK: $w9 = ORRWri $wzr, 1
----------------
`CHECK-NEXT` might be even better here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77852/new/

https://reviews.llvm.org/D77852