[PATCH] D77941: [mlir][spirv] Add a `spirv::InterfaceVarABIAttr`.

Mon Apr 13 10:45:06 PDT 2020

antiagainst accepted this revision.
antiagainst added a comment.
This revision is now accepted and ready to land.

Awesome! Thanks Denis! Just two nits. Feel free to submit after fixing them. :)

================
Comment at: mlir/docs/Dialects/SPIR-V.md:889
+spv-storage-class     ::= `StorageBuffer` | ...
+spv-descriptor-set    ::= integer
+spv-binding           ::= integer
----------------
integer-literal. same for the following

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVAttributes.h:44

+/// An attribute that specifies the information regarding the global variable:
+/// descriptor set, binding, storage class.
----------------
s/global/interface/

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77941/new/

https://reviews.llvm.org/D77941