[PATCH] D77687: [SelectionDAG] Fix usage of Align constructing MachineMemOperands

Mon Apr 13 10:45:05 PDT 2020

efriedma marked an inline comment as done.
efriedma added a comment.

I wasn't really planning to split this, but I can see why you'd want me to.  I can at least split off the MachineMemOperand change from the rest.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:437
   SDValue Ptr = ST->getBasePtr();
-  unsigned Alignment = ST->getAlignment();
   MachineMemOperand::Flags MMOFlags = ST->getMemOperand()->getFlags();
----------------
RKSimon wrote:
> Incidently, should we tag MemSDNode::getAlignment() as LLVM_ATTRIBUTE_DEPRECATED now? We already have this for MemSDNode::getOriginalAlignment().
I don't think it makes sense to mark things deprecated in CodeGen; if they have no uses, we can kill them off.  If they have uses, we can't mark them deprecated because it'll break -Werror builds.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77687/new/

https://reviews.llvm.org/D77687