[PATCH] D77977: [InstCombine] Simplify calls with casted "returned" attribute
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 13 10:45:01 PDT 2020
lebedev.ri added a comment.
I'd prefer for the current patch to proceed as-is first, and for things to be refactored later.
<jdoerfert> LebedevRI: are u OK with the assertion instead of the conditional?
<LebedevRI> if we want to make that an assertion, we should do it in verifier
<LebedevRI> and avoid assertion there at all
<LebedevRI> (there == in the patch at hand)
<LebedevRI> but both the assertion and verifier may find things, so you might want to proceed with the current patch first and refactor later
<jdoerfert> can u add that comment there please. I'll do that then
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77977/new/
https://reviews.llvm.org/D77977
More information about the llvm-commits
mailing list