[PATCH] D76866: Enable new passmanager plugin support for LTO.

[Eli Friedman via Phabricator via llvm-commits]

efriedma marked 2 inline comments as done.
efriedma added inline comments.


================
Comment at: llvm/examples/Bye/Bye.cpp:48
 static llvm::RegisterStandardPasses RegisterBye(
-    llvm::PassManagerBuilder::EP_EarlyAsPossible,
+    llvm::PassManagerBuilder::EP_VectorizerStart,
     [](const llvm::PassManagerBuilder &Builder,
----------------
serge-sans-paille wrote:
> Why did you change the extension point? Not that it's particularly important for that pass, just being curious.
EP_EarlyAsPossible doesn't run for LTO.


================
Comment at: llvm/lib/LTO/LTOBackend.cpp:280
+  }
+
   LoopAnalysisManager LAM;
----------------
serge-sans-paille wrote:
> That's the exact same lines as above. Maybe it's worth putting that in a function?
Yes, probably; I'll factor it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76866/new/

https://reviews.llvm.org/D76866