[PATCH] D78036: Add missing dependencies on the flang test target

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 10:12:24 PDT 2020


mehdi_amini created this revision.
mehdi_amini added reviewers: DavidTruby, sscalpone.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

Without this, the LLVM utilities (FileCheck) aren't built when running
`ninja check-flang` and it fails with:

llvm-project/llvm/utils/lit/lit/llvm/subst.py:134: fatal: Did not find FileCheck in...

Also the modules aren't built without depending on `module_files`, which
makes multiple tests failing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78036

Files:
  flang/test/CMakeLists.txt


Index: flang/test/CMakeLists.txt
===================================================================
--- flang/test/CMakeLists.txt
+++ flang/test/CMakeLists.txt
@@ -18,7 +18,7 @@
   flang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py)
 
 set(FLANG_TEST_DEPENDS
-  f18
+  f18 FileCheck count not module_files
 )
 
 if (LINK_WITH_FIR)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78036.257016.patch
Type: text/x-patch
Size: 343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200413/f7d44d02/attachment.bin>


More information about the llvm-commits mailing list