[PATCH] D78008: [flang] Added Semantic Checks for 5 Data Constraints
Tim Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 13 10:12:22 PDT 2020
tskeith accepted this revision.
tskeith added a comment.
This revision is now accepted and ready to land.
LGTM, after fixing the clang-format problems.
================
Comment at: flang/lib/Semantics/check-data.cpp:27-29
+ std::apply(
+ [&](const auto &... x) { (..., CheckIfConstantSubscript(x)); },
+ triplet.t);
----------------
I think this is clearer as:
```
CheckIfConstantSubscript(std::get<0>(triplet.t));
CheckIfConstantSubscript(std::get<1>(triplet.t));
CheckIfConstantSubscript(std::get<2>(triplet.t));
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78008/new/
https://reviews.llvm.org/D78008
More information about the llvm-commits
mailing list