[PATCH] D78034: [mlir][spirv] Improve stride support in array types

[Lei Zhang via Phabricator via llvm-commits]

antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, frgossen, grosul1, bader, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a reviewer: herhut.
Herald added a project: LLVM.

This commit added stride support in runtime array types. It also
adjusted the assembly form for the stride from `[N]` to `stride=N`.
This makes the IR more readable, especially for the cases where
one mix array types and struct types.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78034

Files:
  mlir/docs/Dialects/SPIR-V.md
  mlir/include/mlir/Dialect/SPIRV/LayoutUtils.h
  mlir/include/mlir/Dialect/SPIRV/SPIRVTypes.h
  mlir/lib/Dialect/SPIRV/LayoutUtils.cpp
  mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
  mlir/lib/Dialect/SPIRV/SPIRVTypes.cpp
  mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp
  mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
  mlir/lib/Dialect/SPIRV/Transforms/DecorateSPIRVCompositeTypeLayoutPass.cpp
  mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp
  mlir/test/Conversion/GPUToSPIRV/load-store.mlir
  mlir/test/Conversion/GPUToSPIRV/simple.mlir
  mlir/test/Conversion/GPUToVulkan/lower-gpu-launch-vulkan-launch.mlir
  mlir/test/Conversion/StandardToSPIRV/std-to-spirv.mlir
  mlir/test/Conversion/StandardToSPIRV/std-types-to-spirv.mlir
  mlir/test/Conversion/StandardToSPIRV/subview-to-spirv.mlir
  mlir/test/Dialect/SPIRV/Serialization/array.mlir
  mlir/test/Dialect/SPIRV/Serialization/constant.mlir
  mlir/test/Dialect/SPIRV/Serialization/loop.mlir
  mlir/test/Dialect/SPIRV/Serialization/memory-ops.mlir
  mlir/test/Dialect/SPIRV/Serialization/struct.mlir
  mlir/test/Dialect/SPIRV/Transforms/abi-interface.mlir
  mlir/test/Dialect/SPIRV/Transforms/abi-load-store.mlir
  mlir/test/Dialect/SPIRV/Transforms/layout-decoration.mlir
  mlir/test/Dialect/SPIRV/structure-ops.mlir
  mlir/test/Dialect/SPIRV/types.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78034.257012.patch
Type: text/x-patch
Size: 70617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200413/e3509e85/attachment.bin>