[PATCH] D77995: [CallSite removal][TargetLowering] Replace ImmutableCallSite with CallBase

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7082
 
-  for (ImmutableCallSite::arg_iterator i = CS.arg_begin(), e = CS.arg_end();
-       i != e; ++i) {
+  for (auto i = CB.arg_begin(), e = CB.arg_end(); i != e; ++i) {
     TargetLowering::ArgListEntry Entry;
----------------
Should we also get 'i' and 'e' to be style-compliant?


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.h:494
                            const SmallVectorImpl<ISD::OutputArg> &,
-                           MaybeAlign retAlignment, ImmutableCallSite CS) const;
+                           MaybeAlign retAlignment, const CallBase *CB) const;
 
----------------
(Here and elsewhere) can CB ever be nullptr? if not, should it be const CallBase &CB (to capture the contract)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77995/new/

https://reviews.llvm.org/D77995