[PATCH] D77576: [globalisel] Add lost debug locations verifier

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

I think this is in good shape overall, but I'll defer to someone with more GISel experience to lgtm this patch.



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LostDebugLocObserver.h:28
+
+  void analyzeDebugLocations();
+
----------------
Can analyzeDebugLocations be private?


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LostDebugLocObserver.h:32
+
+  void checkpoint(bool CheckDebugLocs = true);
+
----------------
The checkpoint method could use some doxygen (when exactly should clients call it, and when should CheckDebugLocs be false)?


================
Comment at: llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:64
+// installed.
+DebugLocVerifyLevel VerifyDebugLocs = DebugLocVerifyLevel::None;
+#endif
----------------
arsenm wrote:
> Missing static const?
This is still missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77576/new/

https://reviews.llvm.org/D77576