[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry' instead of a wrapper around a 'const char'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...

Mon Apr 13 09:07:07 PDT 2020

lattner updated this revision to Diff 256995.
lattner added a comment.

Tidy up some things River requested.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77999/new/

https://reviews.llvm.org/D77999

Files:
  mlir/include/mlir/IR/Identifier.h
  mlir/lib/IR/MLIRContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77999.256995.patch
Type: text/x-patch
Size: 5440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200413/ec843a70/attachment.bin>

[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry*' instead of a wrapper around a 'const char*'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...

[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry' instead of a wrapper around a 'const char'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...