[PATCH] D77101: [AIX] Return the correct set of callee saved regs

Mon Apr 13 08:34:33 PDT 2020

sfertile added a comment.

M

================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:154

   if (TM.isPPC64() && MF->getInfo<PPCFunctionInfo>()->isSplitCSR())
     return CSR_SRV464_TLS_PE_SaveList;
----------------
Minor nit: can we add an error for SplitCC on AIX as well?

================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:170
     // 32-bit targets.
+    if (Subtarget.isAIXABI())
+      report_fatal_error("Cold calling unimplemented on 32-bit AIX.");
----------------
This error should be for both 64-bit and 32-bit AIX targets (We will need to land lit tests + rename the `SVR64_ColdCC` before removing the error for 64-bit).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77101/new/

https://reviews.llvm.org/D77101