[PATCH] D78003: [AMDGPU] Fix llvm.amdgcn.div.scale lowering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:6010
 
-    SDValue Src0 = Param->isAllOnesValue() ? Numerator : Denominator;
+    SDValue Src0 = !Param->isAllOnesValue() ? Numerator : Denominator;
 
----------------
Is there an isNull or something to use instead of negate?


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.div.scale.ll:21
 ; GFX7-NEXT:    s_waitcnt vmcnt(0)
-; GFX7-NEXT:    v_div_scale_f32 v0, s[2:3], v0, v0, v2
+; GFX7-NEXT:    v_div_scale_f32 v0, s[2:3], v2, v0, v2
 ; GFX7-NEXT:    s_mov_b64 s[2:3], s[6:7]
----------------
I checked these were the same order as the final DAG output, so are these inconsistent now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78003/new/

https://reviews.llvm.org/D78003