[PATCH] D77424: [XCOFF][AIX] Relocation support for SymB

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 07:29:48 PDT 2020


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-reloc-symb.ll:38
+  %0 = load i32, i32* %rc.addr, align 4
+  switch i32 %0, label %sw.default [
+    i32 0, label %sw.bb
----------------
hubert.reinterpretcast wrote:
> I'd like a second opinion over whether this is too high-level.
I see your concern. The better way to write the test is through assembly. As you can easly write assembly like 
.csect A[PR]
A:
...
.csect B[RO]
B:
.long A - B
to trigger the relocation emition.
But I doubt the asm parser for AIX works right now. 
And I'm not sure if there are other way to get a better test case for it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77424/new/

https://reviews.llvm.org/D77424





More information about the llvm-commits mailing list