[PATCH] D77869: [VPlan] Introduce VPWidenSelectRecipe (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4420
+
+  auto *ScalarCond = getOrCreateScalarValue(I.getOperand(0), {0, 0});
+
----------------
Ayal wrote:
> A separate, independent nit, while we're here: get or create only values that are needed:
> 
> 
> ```
> auto *ScalarCond = (InvariantCond ? getOrCreateScalarValue(I.getOperand(0), {0, 0}) : nullptr);
> ```
+1, but it requires a few small test changes. I'll fix in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77869/new/

https://reviews.llvm.org/D77869