[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry*' instead of a wrapper around a 'const char*'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 12 23:01:32 PDT 2020
rriddle added inline comments.
================
Comment at: mlir/include/mlir/IR/Identifier.h:83
inline bool operator==(Identifier lhs, Identifier rhs) {
return lhs.data() == rhs.data();
}
----------------
rriddle wrote:
> Can you also fix these while you are at it? These should really just be inline operators that compare the entry.
(By inline I mean in the class)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77999/new/
https://reviews.llvm.org/D77999
More information about the llvm-commits
mailing list