[PATCH] D77879: [ELF][Hexagon] Add duplex to R_HEX_GOT_16_X

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 12 22:27:28 PDT 2020


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Arch/Hexagon.cpp:168
+  // parse field.
+  return ((0xC000 & insn) == 0x0);
+}
----------------
You can remove the extraneous parentheses after `return`. Also, `0x0` should probably be just `0`. Thus

  return (0xC000 & insn) == 0;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77879/new/

https://reviews.llvm.org/D77879





More information about the llvm-commits mailing list