[PATCH] D77927: [MLIR] CMake cleanup for mlir-opt

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/tools/mlir-opt/CMakeLists.txt:10
   ${conversion_libs}
-  MLIRLoopOpsTransforms
   MLIRLoopAnalysis
----------------
stephenneuendorffer wrote:
> mehdi_amini wrote:
> > why is the "transforms" library parts of the "dialect library"?
> Currently all the libraries under lib/Dialect are "Dialect Libraries".  We could make this more fine-grained, I suppose.  
> "Dialect Op Libraries"  "Dialect Transform Libraries" "Dialect Analysis Libraries" "Dialect EDSC libraries" "DialectSerializationLibraries"?
Oh right it makes sense, MLIR_DIALECT_LIBS includes everything, if someone wants to depend on finer grain they can use individual targets.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77927/new/

https://reviews.llvm.org/D77927