[PATCH] D77963: Refactor StringMap.h, splitting StringMapEntry out to its own header.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.

This justification for this split seems along the same lines as the split of DenseMap/DenseMapInfo, so LGTM.



================
Comment at: llvm/include/llvm/ADT/StringMapEntry.h:49
+        second(std::forward<InitTy>(InitVals)...) {}
+  StringMapEntryStorage(StringMapEntryStorage &E) = delete;
+
----------------
nit: E -> entry here and InitVals -> initVals above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77963/new/

https://reviews.llvm.org/D77963