[PATCH] D77927: [MLIR] CMake cleanup for mlir-opt

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 22:24:01 PDT 2020


stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.


================
Comment at: mlir/tools/mlir-opt/CMakeLists.txt:10
   ${conversion_libs}
-  MLIRLoopOpsTransforms
   MLIRLoopAnalysis
----------------
mehdi_amini wrote:
> why is the "transforms" library parts of the "dialect library"?
Currently all the libraries under lib/Dialect are "Dialect Libraries".  We could make this more fine-grained, I suppose.  
"Dialect Op Libraries"  "Dialect Transform Libraries" "Dialect Analysis Libraries" "Dialect EDSC libraries" "DialectSerializationLibraries"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77927/new/

https://reviews.llvm.org/D77927





More information about the llvm-commits mailing list