[PATCH] D73422: [IR] Delete MODULE_CODE_DEPLIB

Sat Apr 11 21:52:03 PDT 2020

MaskRay marked an inline comment as done.
MaskRay added inline comments.

================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3605
-      break;
-    }
     case bitc::MODULE_CODE_SECTIONNAME: {  // SECTIONNAME: [strchr x N]
----------------
mehdi_amini wrote:
> void wrote:
> > mehdi_amini wrote:
> > > Isn't this breaking bitcode backward compatibility?
> > > 
> > This used to be okay when changing major versions. I'm not too familiar with the current versioning system though or whether that's still the policy.
> It changed when we changed the version numbering to not have major/minor anymore. At the time (IIRC) we considered we would break compatibility only if it is really motivated. The current section of the developer policy: https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility
> 
Is this a case that "really no one makes use of the feature"? It was planned to be removed in 4.0

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73422/new/

https://reviews.llvm.org/D73422