[PATCH] D77958: Implement some micro-optimizations for Identifier. NFC

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 19:12:59 PDT 2020


rriddle added a comment.

I wonder if it would be better to just change Identifier to store a `StringMapEntry*` instead of the raw character buffer. That way strref should be O(1).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77958/new/

https://reviews.llvm.org/D77958





More information about the llvm-commits mailing list