[PATCH] D77958: Implement some micro-optimizations for Identifier. NFC

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 18:40:47 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/Identifier.h:54
+  bool is(StringRef string) const {
+    return memcmp(pointer, string.data(), string.size()) == 0 &&
+           pointer[string.size()] == '\0';
----------------
Can you add the justification here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77958/new/

https://reviews.llvm.org/D77958





More information about the llvm-commits mailing list