[PATCH] D76954: LLVM support for BB-cluster sections

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 18:08:39 PDT 2020


MaskRay added a comment.

Hi, it seems that you already got some feedback. I will look at it soon.



================
Comment at: llvm/lib/CodeGen/BBSectionsPrepare.cpp:310
+    // their position within the section.
+    if (XSectionID == YSectionID)
+      return (XSectionID.Type != MBBSectionID::SectionType::Default)
----------------
You can use

```
if (XSectionID != YSectionID)
  return ...
if (... != ...)
  return ...
return ...PositionInCluster < ...;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76954/new/

https://reviews.llvm.org/D76954





More information about the llvm-commits mailing list