[PATCH] D77945: Fixing llvm-shlib to check for the correct host triple on Windows x86

[Tanner Gooding via Phabricator via llvm-commits]

tannergooding created this revision.
tannergooding added a reviewer: whitequark.
tannergooding added a project: LLVM.
Herald added a subscriber: mgorny.

As per https://bugs.llvm.org/show_bug.cgi?id=44127, the CMakeLists.txt for LLVM-C currently checks the wrong host-triple for Windows X86. This results in the official LLVM-C.dll binary being only 9kb in size and containing no exports.

This updates the check to use `i686-pc-windows-msvc`, which is the default triplet selected by CMake, so that the resulting binaries are as expected.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77945

Files:
  llvm/tools/llvm-shlib/CMakeLists.txt


Index: llvm/tools/llvm-shlib/CMakeLists.txt
===================================================================
--- llvm/tools/llvm-shlib/CMakeLists.txt
+++ llvm/tools/llvm-shlib/CMakeLists.txt
@@ -117,7 +117,7 @@
   list(REMOVE_DUPLICATES LIB_NAMES)
 
   # The python script needs to know whether symbols are prefixed with underscores or not.
-  if(LLVM_HOST_TRIPLE STREQUAL "i686-pc-win32")
+  if(LLVM_HOST_TRIPLE STREQUAL "i686-pc-windows-msvc")
     set(GEN_UNDERSCORE "--underscore")
   else()
     set(GEN_UNDERSCORE "")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77945.256775.patch
Type: text/x-patch
Size: 535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200411/ef5ff78d/attachment.bin>