[PATCH] D77935: [MLIR][NFC] Builder InsertionGuard::saveInsertionPoint -> savedInsertionPoint
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 11 02:38:39 PDT 2020
rriddle added a comment.
In D77935#1975923 <https://reviews.llvm.org/D77935#1975923>, @bondhugula wrote:
> In D77935#1975891 <https://reviews.llvm.org/D77935#1975891>, @rriddle wrote:
>
> > This also matches the same verbiage in other parts of LLVM, IRBuilder::saveIP/llvm::SaveAndRestore/etc.
>
>
> Oh I see - the saveInsertionPoint here is used to refer to the insertion point to use for saving?
Yeah, sorry about the short replies. The way that it is intended to be read is that you are saving the current insertion point of the builder and storing it somewhere else. That is why there is the companion restore method, so that you can restore a previously saved insertion point. The reason why "saved" sounds weird is that the builder isn't saving an insertion point, it just has one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77935/new/
https://reviews.llvm.org/D77935
More information about the llvm-commits
mailing list