[PATCH] D77935: [MLIR][NFC] Builder InsertionGuard::saveInsertionPoint -> savedInsertionPoint

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

In D77935#1975886 <https://reviews.llvm.org/D77935#1975886>, @rriddle wrote:

> I'm not +1 on this change. The function is a verb, i.e. it is requesting that the builder "save" the current insertion point inside of an InsertionPoint and return it.


Hmm... but it's not saving the current insertion point. It's only returning the saved one. It's the InsertionGuard ctor that's saving the insertion point. Am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77935/new/

https://reviews.llvm.org/D77935