[PATCH] D77485: [MLIR] Handle in-place folding properly in greedy pattern rewrite driver

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 10 23:57:44 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Transforms/Utils/FoldUtils.cpp:78
+    function_ref<void(Operation *)> preReplaceAction, bool *inPlaceUpdate) {
+  if (inPlaceUpdate)
+    *inPlaceUpdate = false;
----------------
Can we just have this as a precondition? That avoids uninitialized variables being passed in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77485/new/

https://reviews.llvm.org/D77485





More information about the llvm-commits mailing list