[PATCH] D77852: Outline CFI Instructions in Tail Calls

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1167-1169
+      MachineFunction *OriginalMF = I->getMF();
+      const std::vector<MCCFIInstruction> &Instrs =
+          OriginalMF->getFrameInstructions();
----------------
Can we move this out of the loop?


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5866
+  // We check to see if CFI Instructions are present, and if they are
+  // we find the number of CFI Instruction in the cadidates.
+  unsigned CFICount = 0;
----------------
s/Instruction/Instructions/
s/cadidates/candidates/


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5869-5870
+  MachineBasicBlock::iterator Mit = RepeatedSequenceLocs[0].front();
+  for (unsigned Loc =  RepeatedSequenceLocs[0].getStartIdx();
+      Loc <  RepeatedSequenceLocs[0].getEndIdx() + 1; Loc++) {
+    std::vector<MCCFIInstruction> CFIInstructions =
----------------
There are some extra spaces here which can be clang-formatted away


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5881
+
+  // We compare the number of found CFI Instructions to  the number of CFI 
+  // instructions in the parent function for each candidate.  We must check this
----------------
extra space after "to" 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77852/new/

https://reviews.llvm.org/D77852