[PATCH] D77849: [calcspillweights] mark LiveIntervals from INLINEASM_BR defs as not spillable
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 17:16:03 PDT 2020
efriedma added a comment.
> We could check that std::next(MI)->getOpcode == TargetOpcode::INLINEASM_BR, or !std::next(MI).isTerminator(), though I'm not sure what to do in the latter case.
Probably you'd want to check whether the instruction that produces the value is a terminator (which at the moment, should imply it's an INLINEASM_BR).
> Re: 1: I totally do not understand. :( Are you referring to LiveIntervals::splitSeparateComponents?
I was going to try to explain a little more, but then I realized I'm not sure I understand how this would work in practice, so probably I just shouldn't try.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77849/new/
https://reviews.llvm.org/D77849
More information about the llvm-commits
mailing list