[PATCH] D77691: [SVE] Remove calls to isScalable from IR
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 15:37:19 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/IR/Constants.cpp:230
return CFP->getValueAPF().isFiniteNonZero();
- auto *VTy = dyn_cast<VectorType>(getType());
+ auto *VTy = dyn_cast<FixedVectorType>(getType());
if (!VTy)
----------------
This is a functional change, and not really related to the subject of this patch.
================
Comment at: llvm/lib/IR/Function.cpp:1347
+ VectorType *VTy = dyn_cast<FixedVectorType>(Ty);
+ if (!VTy)
return true;
----------------
ctetreau wrote:
> I think this might not be correct
Yes, `!VTy || !VTy->isScalable()` is equivalent to `!isa<ScalableVectorType>(Ty)`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77691/new/
https://reviews.llvm.org/D77691
More information about the llvm-commits
mailing list