[PATCH] D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC.

Fri Apr 10 15:06:14 PDT 2020

nathanchance added a comment.

In D73664#1975208 <https://reviews.llvm.org/D73664#1975208>, @nemanjai wrote:

> In D73664#1975159 <https://reviews.llvm.org/D73664#1975159>, @nathanchance wrote:
>
> > In D73664#1975045 <https://reviews.llvm.org/D73664#1975045>, @nemanjai wrote:
> >
> > > This is also a regression after this patch or something that was broken before?
> >
> >
> > Yes. If I checkout to f3bf25eb663c49e821120fd311677764d2bad79e <https://reviews.llvm.org/rGf3bf25eb663c49e821120fd311677764d2bad79e>, `modules` builds successfully but with 6c4b40def77622a5cf62a219ef4af63dc876e144 <https://reviews.llvm.org/rG6c4b40def77622a5cf62a219ef4af63dc876e144>, I get that error, with or without 5b18b6e9a84d985c0a907009fb71de7c1943bc88 <https://reviews.llvm.org/rG5b18b6e9a84d985c0a907009fb71de7c1943bc88>.
>
>
> Awesome. Thank you. I'll work on getting that fixed. To verify everything, I just replace `modules` in the invocation with `all`?

Correct!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73664/new/

https://reviews.llvm.org/D73664