[PATCH] D74877: [clang] fix incorrect Wdocumentation fix-its

[Alexander Lanin via Phabricator via llvm-commits]

AlexanderLanin planned changes to this revision.
AlexanderLanin marked 10 inline comments as done.
AlexanderLanin added a comment.

I need to have a look why the mentioned test case is failing. I'll also add the two examples you provided to the next upload.



================
Comment at: clang/lib/AST/CommentSema.cpp:735
+                                        bool IsFunctionOrMethodVariadic) {
+  for (unsigned i = 0, e = ParamVars.size(); i != e; ++i) {
+    const IdentifierInfo *II = ParamVars[i]->getIdentifier();
----------------
Mordante wrote:
> Please capitalize the `i` and `e`.
Sorry such stuff should not require a manual review. I fixed this and similar issues by running `clang-tidy --checks="readability-identifier-naming" -p=/home/alex/llvm/build CommentSema.cpp --fix`


================
Comment at: clang/test/Sema/warn-documentation-fixits.cpp:74
+
+// This test matches bug report at https://bugs.llvm.org/show_bug.cgi?id=43808.
+// Note: first parameter is the same as above, bug gets auto fixed here since
----------------
Mordante wrote:
> Why use a different test case than in the bug report? I really would like to see this patch fixes that case.
You are totally right. Added test case; It's failing; needs analysis. I thought I had that fixed. Will check ASAP.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74877/new/

https://reviews.llvm.org/D74877