[PATCH] D77886: [mir-strip-debug] Optionally preserve debug info that wasn't from debugify/mir-debugify

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 10 14:32:32 PDT 2020


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Looks good! I'll send a follow up change so we can share some of the stripping logic with the IR-level debugify pass.



================
Comment at: llvm/lib/CodeGen/MachineStripDebug.cpp:30
+      if (!DebugifyMD) {
+        LLVM_DEBUG(dbgs() << "Leave debug info not from debugify\n");
+        return false;
----------------
dsanders wrote:
> aprantl wrote:
> > `Stripping only debug info added by the debugify pass.`?
> That sounds like it's stripping debug info when it's not stripping it.
> `Not stripping debug info (debugify metadata not found)`?
Sgtm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77886/new/

https://reviews.llvm.org/D77886





More information about the llvm-commits mailing list